cppcheck: fix missing field initializers in constructor#3752
Merged
andypugh merged 1 commit intoLinuxCNC:masterfrom Jan 29, 2026
Merged
cppcheck: fix missing field initializers in constructor#3752andypugh merged 1 commit intoLinuxCNC:masterfrom
andypugh merged 1 commit intoLinuxCNC:masterfrom
Conversation
Collaborator
Contributor
Author
|
Ehm, yes, that is actually the commit I created in this PR. Why are you telling it is "partially addressed"? Rerunning cppcheck with the proposed changes removes the particular warnings. It does not remove all cppcheck warnings, but that was never the intention. I'd like to keep these types of change sets isolated if they ever need to be bisected. |
Collaborator
I pasted to the wrong browser tab. I meant to point to your PR from #3746 . |
Contributor
Author
|
Ah, yes, that explains it :-) But now it seems to be an academic discussion because it is already merged. That should be no problem for #3746 as these hunks would simply be skipped when that is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new S-curve TP caused several missing constructor field init problems seen by cppcheck.
Also included is the removal of a #pragma to ignore missing initializers that was inappropriate.